-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109016/
-----------------------------------------------------------
Review request for Plasma, Petri Damstén and Shaun Reich.
Description
-------
The Disk Usage and Disk Usage monitoring applets (from
kde-workspace/plasma/generic/applets/system-monitor/) have layout problems when
they are resized. Specifically, with large sizes and few plots it becomes
apparent that there is a spurious blank space at the bottom of the applets. The
problem derives form these lines:
setTitle(i18n("Disk Space"), true);
setTitle(i18n("Disk Activity"), true);
The "true" argument triggers some old code that adds a spacer in the layout,
which I guess was used to insert some space below the header, but that now has
lost its purpose (see http://websvn.kde.org/?view=revision&revision=816676).
This submission removes this code and restores proper layout for the applets.
Diffs
-----
plasma/generic/applets/system-monitor/hdd_activity.cpp bc30a33
plasma/generic/applets/system-monitor/applet.h f8fe437
plasma/generic/applets/system-monitor/applet.cpp 653eacd
plasma/generic/applets/system-monitor/hdd.cpp 5762d6d
Diff: http://git.reviewboard.kde.org/r/109016/diff/
Testing
-------
Compiled and tested. Patch applies to both master and KDE/4.10.
Thanks,
Gregorio Guidi
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
