> On Feb. 16, 2013, 10:36 p.m., Hrvoje Senjan wrote: > > Maybe to slightly reduce controls size? This made controls gigantic here. > > Otherwise, great improvement :-) > > Tjaart Blignaut wrote: > Could you post a screen shot. I changed the icon sizing policy but in > general the idea was to make the controls larger. You can check the latest > diff to see if it solves the problem for you. > > Hrvoje Senjan wrote: > Sure. http://i.imgur.com/xhr1EDA.png > This is with diff3 > > Tjaart Blignaut wrote: > You don't like this control size? It was intended to be this large > because relative to everything else the controls were quite small. 22x22 > probably. Now they are 32x32? Is there any specific policy with regards to > size that should be followed? I also noticed that the controls are the only > thing that is different in your case, and not the font sizes which are also > modified? > > Hrvoje Senjan wrote: > Well, as said, i find them a bit huge :-) > Yes, text appears to be the same as it was before, but i don't see you > touching size of it in the diff? Also, no bold here, and in the patch. > Maybe not the patch you wanted to push?
Okay I think I fixed the diff. I messed it up due to my confusing workflow. See if you agree that tiny icons will not fit with the larger fonts? - Tjaart ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108969/#review27559 ----------------------------------------------------------- On Feb. 18, 2013, 10:18 p.m., Tjaart Blignaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108969/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 10:18 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch > - allows the now playing widget to automatically size text when the widget is > sized. The sizing is a function of height with some of the width also causing > teh text to size. > - makes the play controls slighty bigger and easier to press > - Adds some margins to all the controls > - makes the progress bar a bit fatter > - Removed the "by" and "on" text > > > Diffs > ----- > > applets/nowplaying/package/contents/ui/Controls.qml 382ccf6 > applets/nowplaying/package/contents/ui/FullLayout.qml c92f5c6 > applets/nowplaying/package/contents/ui/MetadataPanel.qml dc01be6 > > Diff: http://git.reviewboard.kde.org/r/108969/diff/ > > > Testing > ------- > > Tested with some really long tracks like "Counting bodies like sheep with the > rythm of the war drum" to see if sizing would work. Tested it on 22" monitor > and on 32" television. Sized it to fill each screen horizontally and fill the > screen half way vertically. > > > File Attachments > ---------------- > > Before > > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png > After > > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png > With play controls > > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/nowplaying_after_with_widgets.png > > > Thanks, > > Tjaart Blignaut > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
