----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108957/ -----------------------------------------------------------
(Updated Feb. 14, 2013, 1:02 p.m.) Review request for kwin and Plasma. Changes ------- adding Plasma to review groups as it adds an optional build dep to workspaces and is also interesting for plasma Description ------- Adding BAMF support to KWin BAMF is a library used by Unity to match windows to their applications. This is also pretty useful for KWin, possible uses are: * better filtering on whether two Clients belong to the same application * Using the application name as caption in case the window title is bad * Getting better icons for window switcher/decorations, mostly important for high resolution displays as icons provided through X property do not include the large icons (e.g. 128x128) * Using application name for application menu button So far support is added to get the KDesktopFile for a Client and this is exported to KWinEffects. BAMF is probably also useful in other areas of the workspaces, e.g. for libtaskmanager. Diffs ----- CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 cmake/modules/CMakeLists.txt 8d3d58189dbcb9e89d4d9c9aa4f3c1c93abad5e4 cmake/modules/FindQtBAMF.cmake PRE-CREATION config-workspace.h.cmake 4a2dcbf481bff35c3b05366a3d1a79bb1f400b88 kwin/CMakeLists.txt 2f44c57066913e05062bc1a3c3d8a03e924906dc kwin/client.h 4cbc20f8e2b3aa31c1c33d63ae90f1f0c9eeefbf kwin/client.cpp 2ce68fb4a0f108442b3476d39a90895bb1d12ffb kwin/libkwineffects/kwineffects.h 464d7f2c3261c389dcf2349168b8d67cb691563a kwin/libkwineffects/kwineffects.cpp 7d522d11e1cc71598e646c972c37f1af2275c3fc Diff: http://git.reviewboard.kde.org/r/108957/diff/ Testing ------- Thanks, Martin Gräßlin
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel