----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108800/#review26742 -----------------------------------------------------------
Ship it! plasmate/mainwindow.cpp <http://git.reviewboard.kde.org/r/108800/#comment20300> could be const QString :) - Aaron J. Seigo On Feb. 6, 2013, 11:18 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108800/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 11:18 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Make plasmate to not accept packages which doesn't specify the servicetype. > Without the servicetype plasmate can't choose the appropriate editor for the > package. > > With this patch plasmate is using a kmessagebox in order to show the error, > should it be a kmessagewidget? > > > Diffs > ----- > > plasmate/mainwindow.cpp 53c4502 > > Diff: http://git.reviewboard.kde.org/r/108800/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
