----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108640/#review26308 -----------------------------------------------------------
This review has been submitted with commit 6e626a7c6ace1b1101d7db512c8c129d3bb32811 by David E. Narváez to branch KDE/4.10. - Commit Hook On Jan. 28, 2013, 12:40 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108640/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 12:40 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Related to bug 312137. According to the documentation, the wallet pointer can > be null if it was denied, so we need to check for null values before the > other checks. > > > Diffs > ----- > > dataengines/microblog/koauth.cpp 7566b95 > > Diff: http://git.reviewboard.kde.org/r/108640/diff/ > > > Testing > ------- > > 1. Make sure your plasma desktop does not have "Allow Always" in your kwallet > 2. Add a microblogging plasmoid > 3. Configure your plasmoid with an identi.ca account > 4. Deny any kwallet prompt > > Before this path it would crash trying to store the access tokens. > > > Thanks, > > David Narváez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
