----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108559/ -----------------------------------------------------------
Review request for Plasma and Marco Martin. Description ------- 1. string in qml doesn't have "empty" property, use length to check it's empty or not. 2. AccelButton's string doesn't have &, which will result in unpressable accel key when process i18n string (for example Chinese). (since we are already string freeze.. this part might not go into KDE/4.10) 3. AccelButton will display & if showAccel is false, here we introduce a new property for normal string 4. fallback to loginName if fullName is empty. 5. console.log in AccelButton is removed. Diffs ----- ksmserver/screenlocker/greeter/greeterapp.cpp 32a4d16 ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/AccelButton.qml 108a39d ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 65e348d Diff: http://git.reviewboard.kde.org/r/108559/diff/ Testing ------- user name is shown as expected. accel key will work for i18n case. Thanks, Xuetian Weng
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
