-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108525/
-----------------------------------------------------------
(Updated Jan. 22, 2013, 12:47 p.m.)
Review request for Plasma and Aaron J. Seigo.
Changes
-------
Dropped the hardcoded colors.
If this looks fine, i would *really* appreciate if someone could commit it, as
i don't have the rights :-)
Description
-------
Patch adds ButtonBackgroundColor to PaletteHelper. Not sure it's the best way
for fixing the bugs, but it works :-)
Problem is only exposed in combination of light colorschemes and dark plasma
themes which don't have a light button (so have the same button text color as
for window text).
This addresses bugs 263979 and 310389.
http://bugs.kde.org/show_bug.cgi?id=263979
http://bugs.kde.org/show_bug.cgi?id=310389
Diffs (updated)
-----
plasma/private/themedwidgetinterface.cpp 399033c
Diff: http://git.reviewboard.kde.org/r/108525/diff/
Testing
-------
Compiled master kdelibs with the patch, works as advertised.
Did not found any other user of Plasma::CheckBox, Plasma::RadioBox and
Plasma::TreeView, so tested only with networkmanagement (nm09 branch) plasmoid.
File Attachments
----------------
Current behaviour
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/21/before.png
With patch
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/21/after.png
Thanks,
Hrvoje Senjan
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
