----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108453/#review25884 -----------------------------------------------------------
looks nice (just some small nitpicks in the ui) as procedure, now it should be in integration for a while(Aaron, can you do it?) , tested, and hopefully merged in few days also, the applet should be in the default setup by changing the default plasma-device-appetsrc in the plasma-mobile-config repo applets/orientation/contents/code/Orientation.qml <http://git.reviewboard.kde.org/r/108453/#comment19793> importQtQuick 1.1 instead of Qt 4.7 applets/orientation/contents/code/Orientation.qml <http://git.reviewboard.kde.org/r/108453/#comment19794> if the default width seems to be too big, try to give it preferredWidth or maximumwidth as well applets/orientation/contents/code/Orientation.qml <http://git.reviewboard.kde.org/r/108453/#comment19792> use theme.mediumIconSize instead of 32 - Marco Martin On Jan. 17, 2013, 8:31 p.m., Jeremy Paul Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108453/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2013, 8:31 p.m.) > > > Review request for Plasma, Aaron J. Seigo and Marco Martin. > > > Description > ------- > > This adds an orientation dataengine to plasma which reacts to qt sensors and > also takes commands via the orientation applet to rotate left or right. > Rotation rotates both the touch screen device via xinput calls and the x > screen via libkscreen. > > TODO: Add a lock/unlock to the applet once qt sensors are providing input. > > also, I'm not sure why the orientation applet expansion is so wide, it really > only needs to accomodate those two icons. > > > Diffs > ----- > > CMakeLists.txt 7d030f0bd962225b9787bb8a1ff8037dd21a0b3c > applets/CMakeLists.txt f33ba4066b32df625ac143698d5e546ca302e523 > applets/orientation/Messages.sh PRE-CREATION > applets/orientation/contents/code/Orientation.qml PRE-CREATION > applets/orientation/metadata.desktop PRE-CREATION > cmake/modules/FindQtMobility.cmake PRE-CREATION > dataengines/CMakeLists.txt c9bfa9358bd6eeb3773b811c46a043305abd60f7 > dataengines/orientation/CMakeLists.txt PRE-CREATION > dataengines/orientation/orientation.operations PRE-CREATION > dataengines/orientation/orientationengine.h PRE-CREATION > dataengines/orientation/orientationengine.cpp PRE-CREATION > dataengines/orientation/orientationjob.h PRE-CREATION > dataengines/orientation/orientationjob.cpp PRE-CREATION > dataengines/orientation/orientationservice.h PRE-CREATION > dataengines/orientation/orientationservice.cpp PRE-CREATION > dataengines/orientation/plasma-engine-orientation.desktop PRE-CREATION > > qmlpackages/contour-tablet-homescreen/contents/config/plasma-default-layoutrc > 98d9b7316eb543a172b49ae4cb8110c87d189a56 > > Diff: http://git.reviewboard.kde.org/r/108453/diff/ > > > Testing > ------- > > > Thanks, > > Jeremy Paul Whiting > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
