----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108480/#review25817 -----------------------------------------------------------
This change is wrong imho. If 'Confirm logout' is disabled it should not ask for confirmation. Otherwise what's the point of that option? Showing the dialog depending on the button clicked breaks UI expectations a lot more than the presence of ellipses. Perhaps remove the ellipses if the confirmation is disabled? (And show them in Kickoff/Tool box when enabled) If people keep losing work due to hitting 'leave' by accident, there is a solution for that: Confirm logout. Note: just my personal opinion and I'm not a plasma developer. - Maarten De Meyer On Jan. 19, 2013, 7:37 a.m., Jacob Welsh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108480/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2013, 7:37 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Description from bug: > > There's a logout option in the desktop context menu named "Leave...". The > presence of ellipses indicates to the user that there will be a confirmation > dialog. However, if you've disabled "Confirm logout" in System Settings / > Startup and Shutdown / Session Management, no such confirmation will be > given. This breaks UI expectations and could lead to loss of unsaved work. (I > still prefer to disable confirmation for the case of the kickoff menu items, > which don't have ellipses and are harder to hit "by accident".) > > > This addresses bug 313480. > http://bugs.kde.org/show_bug.cgi?id=313480 > > > Diffs > ----- > > plasma/generic/containmentactions/contextmenu/menu.cpp bfd60a1 > > Diff: http://git.reviewboard.kde.org/r/108480/diff/ > > > Testing > ------- > > None. Sorry, I gave up on getting all the KDE components built from git for > the time being; was getting one error after another. If there's a quick way > to test just the plasma workspace I'd be happy to try. > > > Thanks, > > Jacob Welsh > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
