----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108422/#review25599 -----------------------------------------------------------
This review has been submitted with commit 11c7b2d6453b016769af66b189d00046b507ea5c by Aurélien Gâteau to branch KDE/4.10. - Commit Hook On Jan. 15, 2013, 12:05 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108422/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 12:05 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > QML containments can provide a config.ui file to allow the user to configure > them, but BackgroundDialog did not show it. This patch adds a page to the > dialog if a QML containment provides a config.ui file. The code is based on > the code used to show the configuration dialog of QML applets. > > PS: The patch from https://git.reviewboard.kde.org/r/108423/ is required for > the "Apply" button to work. > > > Diffs > ----- > > libs/plasmagenericshell/backgrounddialog.cpp a486ba5 > > Diff: http://git.reviewboard.kde.org/r/108422/diff/ > > > Testing > ------- > > Tested with the text-shadows branch of kde:homerun. Also used and configured > other non-QML containment like Folder View to ensure the change does not > introduce regressions. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
