-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108425/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
Series consists of 3 commits:
* Refactor grace time tracking
Set a boolean instead of checking whether timer is active. This is
required for the following commits.
* Stop grace period on unlock
It was safe to leak the grace timer when it was in the lock process,
since it was killed on unlock. Now it is not.
A password should always be required if the screenlocker is explicitly
triggered; but a screenlocker invoked while the grace timer from a
previous invocation is still active can be dismissed without a password,
at least for a short while. This also meant that the screenlocker
keyboard shortcut would not work until the grace timer expired.
* Respect Lock boolean in configuration
If not set to require password, don't start the grace period timer and
always consider in grace period.
This addresses bug 310871.
http://bugs.kde.org/show_bug.cgi?id=310871
Diffs
-----
ksmserver/screenlocker/ksldapp.h 51c0906fc6e54787af749872615770bd6005b4fb
ksmserver/screenlocker/ksldapp.cpp c07ac0ef1c6643415b8c13ba438628a1e118fb72
Diff: http://git.reviewboard.kde.org/r/108425/diff/
Testing
-------
Tested with and without password required, tested with grace time set to zero
in config file. Tested idle activation, user-requested activation and behaviour
after return from idle activation.
Thanks,
Oliver Henshaw
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
