----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108375/#review25517 -----------------------------------------------------------
This review has been submitted with commit ed7b99f14f52b9ab43b06996af1e5f36a50c4d77 by Thomas Lübking to branch master. - Commit Hook On Jan. 13, 2013, 9:32 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108375/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2013, 9:32 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Description > ------- > > Ok. Redirecting to plasma. > > The patch fixes: > > a) setting the properties > ... to happen on show, this is required because the "hide()" will (usually > and in this case) destroy the drawable ("window") and with it all properties > on the server; so they need to be re/set "when required". > > b) input processing > Relevant events are sucked so that we don't receive them more than once > (usually i'd discourage from installing an eventfilter on the application but > the screenlocker is ideally of low event occurrance anyway) > > c) triggering events > Not really a fix but the "saver" is now hidden on any keyPress and only > reshown on escape keyRelease (iirc this was the behavior of most screenSavers > when i used them because there was no dpms ...) > > d) screen geometry adaptation > if the user attaches a screen and that auto-extends the desktop, the > screenlocker currently yells a warning and happily exposes the desktop > (there's still a problem in case KWin fades in the locker but that's not > matter to this patch) > > > This addresses bug 311116. > http://bugs.kde.org/show_bug.cgi?id=311116 > > > Diffs > ----- > > ksmserver/screenlocker/greeter/greeter.cpp f5918f9 > ksmserver/screenlocker/greeter/greeterapp.h 6b2c263 > ksmserver/screenlocker/greeter/greeterapp.cpp a35c8ae > ksmserver/screenlocker/greeter/screensaverwindow.cpp adb2587 > > Diff: http://git.reviewboard.kde.org/r/108375/diff/ > > > Testing > ------- > > "Screensaver" - Emulation ;-) > > m_showScreenSaver = true; > // screensaverWindow->setBackground(backgroundPix); > screensaverWindow->setAutoFillBackground(true); > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
