----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108115/#review24858 -----------------------------------------------------------
Ship it! I would leave the label, maybe remove the parenthesis but I'd say it's good to have the label, since when there's some text you can't read the placeholder. I think the code is better now and it should get in, I'll mark as Ship It although I understand I don't have much of a say in this code. :) - Aleix Pol Gonzalez On Jan. 5, 2013, 4:18 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108115/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2013, 4:18 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Hello, > > In this patch i am replacing the QDialogButtonBox with theQVBoxLayout. > Also i have increase the size of the dialog, because it was too small for the > labels. > > > Diffs > ----- > > plasmate/savesystem/commitdialog.cpp cf7cb1f > > Diff: http://git.reviewboard.kde.org/r/108115/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > after > http://git.reviewboard.kde.org/r/108115/s/980/ > before > http://git.reviewboard.kde.org/r/108115/s/981/ > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
