> On Jan. 6, 2013, 3:25 p.m., Kai Uwe Broulik wrote: > > The code basically is fine, except that you could make the OSD a bit wider > > (increase width) like the old one. > > > > There is a problem on the Plasma side, however. I adapted your code for > > KMix which also suffers the same problem, and in KMix it works perfectly. > > In PowerDevil, however, I see no change, I get a fully-opaque white > > background dialog with no shadows. I guess this is because PowerDevil > > starts quite early in the startup process and so Plasma (and probably the > > compositor) is not up and running. Seems that broken detection when > > compositing state changes (https://bugs.kde.org/show_bug.cgi?id=179042) is > > the cause.
Well.. at least you can test with: kquitapp kded; sleep 1; kded4 To see if we don't consider that bug, it will work or not. - Xuetian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24834 ----------------------------------------------------------- On Jan. 6, 2013, 1:36 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108222/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2013, 1:36 p.m.) > > > Review request for kde-workspace, Plasma and Aaron J. Seigo. > > > Description > ------- > > well, you know.. this would fix the shadow problem, and clean up code > actually. > > > Diffs > ----- > > powerdevil/daemon/brightnessosdwidget.h ef08903 > powerdevil/daemon/brightnessosdwidget.cpp e4cf80a > > Diff: http://git.reviewboard.kde.org/r/108222/diff/ > > > Testing > ------- > > locally tested, no problem. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
