----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/#review22561 -----------------------------------------------------------
plasmate/CMakeLists.txt <http://git.reviewboard.kde.org/r/107470/#comment17247> I'm wondering if we really need to add a kdepimutils dependency for a simple email validation... Thoughts about that? In any case, "kpimutils" must be discarded and substituted with the more portable ${KDEPIMLIBS_KPIMUTILS_LIBS} (more info inside FindKdepimLibs.cmake file). - Diego Casella On Nov. 26, 2012, 10:36 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107470/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2012, 10:36 a.m.) > > > Review request for Plasma. > > > Description > ------- > > On this patch i am replace the QRegExp on SigningDialog::validateParams() > with KPIMUtils::isValidSimpleAddress > > > Diffs > ----- > > plasmate/CMakeLists.txt 111c402 > plasmate/publisher/signingdialog.cpp 395138d > > Diff: http://git.reviewboard.kde.org/r/107470/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
