-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107418/#review22379
-----------------------------------------------------------
Ship it!
ouch! all that just for the needed result. too bad actions don't have a
non-translated identifier :/
looks good except for some minor ws issues, e.g. "if (names.contains
(e.attribute ("name"))) {" should be "if (names.contains(e.attribute("name")))
{"
fix up the ws and shipit :)
- Aaron J. Seigo
On Nov. 22, 2012, 11:59 a.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107418/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2012, 11:59 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> If plasmate's ui is in english the "save" and "save us" actions are
> invisible, but not for the rest of the languages.
> This patch solves the issue.
>
>
> Diffs
> -----
>
> plasmate/editors/text/texteditor.h 6fb362c
> plasmate/editors/text/texteditor.cpp 14bccf6
> plasmate/mainwindow.cpp 87d6fe3
>
> Diff: http://git.reviewboard.kde.org/r/107418/diff/
>
>
> Testing
> -------
>
> it works, see the image
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/107418/s/849/
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
