> On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote: > > This review has been submitted with commit > > e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch > > push/4.9. > > Christoph Feck wrote: > "push/4.9" is not a valid branch name for kde-workspace. If these commits > should be part of KDE 4.9.3 release, you need to push or cherry-pick them to > branch "KDE/4.9". Please ask maintainers how to proceed. > > Oliver Henshaw wrote: > Ah yes, my embarassing mistake. The commits did eventually reach KDE/4.9 > as intended, not sure why reviewboard didn't register that.
KDE's Git Hooks will only process a commit once (recognition is done by the SHA-1 hash of the commit). If you did a plain merge or just pushed to the wrong destination then the hooks would not have done reprocessed the commit when it landed in KDE/4.9. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review21307 ----------------------------------------------------------- On Oct. 10, 2012, 3:13 p.m., Oliver Henshaw wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106784/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2012, 3:13 p.m.) > > > Review request for Plasma and Solid. > > > Description > ------- > > Fix battery applet screen power management > > Connect to the correct job when beginning/stopping > SuppressingScreenPowerManagement. The pasto in the "stop" case was > probably harmless; in the "begin" case we need to store the correct > cookie in order to later stop the suppression. > > > Diffs > ----- > > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml > 72bb8ec8f9339f2d639267bbc435c1f0f76ecac7 > > Diff: http://git.reviewboard.kde.org/r/106784/diff/ > > > Testing > ------- > > Tested timed screen & session power management before, during and after > inhibit with battery applet. > > > Thanks, > > Oliver Henshaw > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
