----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/#review21141 -----------------------------------------------------------
plasmate/editors/editpage.cpp <http://git.reviewboard.kde.org/r/106680/#comment16557> yes, so it should use startsWith :) the code in the current patch is functionally equivalent to: const QString themeType = "[plasmate]/themeImageDialog/"; if (mimetype.startsWith(themeType)) { const QString opts = "cotents/" + mimetype.right(mimetype.size() - themeType.length()); imageDialog(commonFilter, opts); } - Aaron J. Seigo On Oct. 4, 2012, 10:49 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106680/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2012, 10:49 a.m.) > > > Review request for Plasma. > > > Description > ------- > > create a new theme package->click on the new > > a file dialog should appear but instead a simple edit box appears requesting > a new filename. > > This patch solves the issue > > > Diffs > ----- > > plasmate/editors/editpage.h 8cc5fab > plasmate/editors/editpage.cpp 91f6bce > plasmate/packagemodel.cpp 67cc0f4 > > Diff: http://git.reviewboard.kde.org/r/106680/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
