> On Oct. 23, 2012, 7:01 a.m., Ivan Čukić wrote: > > You didn't have to bother with screenshots, your word would be sufficient :)
No problem ;) Btw, should I commit into master and 4.9, or just master? - Diego ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20718 ----------------------------------------------------------- On Oct. 22, 2012, 11:01 p.m., Diego Casella wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106999/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2012, 11:01 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > When you open the Activity Manager, and click the "Configure" button, the > stacked config page displays a misplaced iconButton (see figure on the left). > That's because, in ActivityDelegate, the implicitHeight of the component is > forced to 20. > Funny observation: this weird behavior shows up only when Activity Manager is > displayed horizontally ... Vertically, everything is just fine. > Anyway the "patch" is just an one-liner so it should be OK, I suppose. > The fixed component is shown in the screenshot on the right. > > > Diffs > ----- > > > plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml > 4af21e7 > > Diff: http://git.reviewboard.kde.org/r/106999/diff/ > > > Testing > ------- > > Works perfectly, both with horizontal and vertical placement (see shots > below). > > > Screenshots > ----------- > > Activity Manager, before > http://git.reviewboard.kde.org/r/106999/s/790/ > Activity Manager, after > http://git.reviewboard.kde.org/r/106999/s/791/ > Activity Manager, Androbit theme > http://git.reviewboard.kde.org/r/106999/s/792/ > Activity Manager, Aya theme > http://git.reviewboard.kde.org/r/106999/s/793/ > Activity Manager, Produkt theme > http://git.reviewboard.kde.org/r/106999/s/794/ > Activity Manager, Slim Glow theme > http://git.reviewboard.kde.org/r/106999/s/795/ > Activity Manager, Tibanna theme > http://git.reviewboard.kde.org/r/106999/s/796/ > > > Thanks, > > Diego Casella > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
