----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106818/#review20240 -----------------------------------------------------------
Ship it! looks good; small style comment below. plasma/declarativeimports/plasmaextracomponents/qml/animations/DisappearAnimation.qml <http://git.reviewboard.kde.org/r/106818/#comment15980> please put these on one line each as we do with other properties - Aaron J. Seigo On Oct. 13, 2012, 12:49 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106818/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2012, 12:49 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Initial values have simply been forgotten, values have been chosen matching > AppearAnimation. Patch is intended for KDE/4.9 and master. > > > Diffs > ----- > > > plasma/declarativeimports/plasmaextracomponents/qml/animations/DisappearAnimation.qml > 1448161 > > Diff: http://git.reviewboard.kde.org/r/106818/diff/ > > > Testing > ------- > > animated a FrameSvgItem appearing and disappearing, works as expected, no > apparent side effects. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
