----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106797/#review20215 -----------------------------------------------------------
This review has been submitted with commit 9e5a50dcd69bf4844af6ecca9555f5b1db67121e by David Edmundson to branch KDE/4.9. - Commit Hook On Oct. 11, 2012, 3:09 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106797/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2012, 3:09 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Fix padding to the left and right of text in a textField > > Text was already fontSize*1.6 meaning there was a 0.3 textHeight padding on > the top and bottom. Padding on the left and right was completely missing. > It's fairly typical to make the padding on the top and bottom match left and > right. > > If this patch gets accepted I'll make the same change in TextArea. > > Before and after shots show it best. > > > Diffs > ----- > > plasma/declarativeimports/plasmacomponents/qml/TextField.qml > 201b61b958a04b621ccb20abbc5f1d7cfeea6798 > > Diff: http://git.reviewboard.kde.org/r/106797/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > Before > http://git.reviewboard.kde.org/r/106797/s/766/ > After > http://git.reviewboard.kde.org/r/106797/s/767/ > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
