----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106743/#review19989 -----------------------------------------------------------
Ship it! after perusing both the code in plasma-desktop and libplasma, this looks like dead code. - Aaron J. Seigo On Oct. 5, 2012, 6:59 p.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106743/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2012, 6:59 p.m.) > > > Review request for Plasma. > > > Description > ------- > > this patch looks trivial, but I get the bad feeling that this change could > cause regressions. What was the purpose of that early exit in the first place? > > > This addresses bug 263947. > http://bugs.kde.org/show_bug.cgi?id=263947 > > > Diffs > ----- > > plasma/desktop/toolboxes/internaltoolbox.cpp > b62370e8a428087bb7671b60632e8fe458d1ee67 > > Diff: http://git.reviewboard.kde.org/r/106743/diff/ > > > Testing > ------- > > no issues noted > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
