----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106714/#review19844 -----------------------------------------------------------
Ship it! Well, I'm really fine with it. One remark -- see below. libs/main/CMakeLists.txt <http://git.reviewboard.kde.org/r/106714/#comment15763> we generally put this in an if statement -- like we do for soprano. - Boudewijn Rempt On Oct. 3, 2012, 5:12 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106714/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2012, 5:12 p.m.) > > > Review request for Calligra and Plasma. > > > Description > ------- > > Calligra applications report the open/close document events to activity > manager daemon. > > Side-effect - support for Share-Like-Connect applet. > > > Diffs > ----- > > CMakeLists.txt 04d35c3 > KoConfig.h.cmake 02f40c3 > libs/main/CMakeLists.txt 3653de2 > libs/main/KoMainWindow.cpp 8eb8dff > > Diff: http://git.reviewboard.kde.org/r/106714/diff/ > > > Testing > ------- > > Tested with flow, words and krita. > > > Screenshots > ----------- > > SLC > http://git.reviewboard.kde.org/r/106714/s/753/ > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
