> On Oct. 1, 2012, 10:34 a.m., Aaron J. Seigo wrote: > > i think this change is necessary and can go in. however, the model MUST > > then be fixed to at least show all non-created files described in the > > package as well otherwise things like creating new images or populating the > > default settings will be hard/impossible for the user and making that easy > > is plasmate's #1 purpose in life. :)
> the model MUST then be fixed to at least show all non-created files described > in the package It will be fixed by then :) - Giorgos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106665/#review19676 ----------------------------------------------------------- On Oct. 1, 2012, 8:46 a.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106665/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2012, 8:46 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Until now plasmate was creating all the Package::files() on the load of the > project, > with this patch it will create only the Package::requiredFiles(). > > Also we **have** to s/Package::files()/Package::requiredFiles(), because > right now > 1. the Plasma themes are broken: > plasmate creates all the listing files of the theme package with QFile,so > QSvgRenderer can't > open them, and if the user adds one more foo.svgz file, he will end up with 2 > foo.svg files and > even if he deletes the corrupted one it will be recreated on the next load > > 2. plasmate forces the user to have a main.xml and a default-configrc, also > even if the user deletes > those files, on the reload they will be recreated. > > I haven't s/Package::dirs()/Package::RequiredDirs() because we don't have any > ui element in order to > inform the user that the foo dir(for examples the images or the animations > dir) exists, so he will have to > figure it out and create it manually and even if he does the dirs won't > appear in the plasmate's package model. > > > The only drawback of this patch is that the user won't see anymore the > description of the file but he will see their names. > > I believe that for the moment we should add this patch and to fix the > PackageModel issues after the beta. > > > P.S.: I replaced some deprecated methods. > > > Diffs > ----- > > packagemodel.cpp d9cc35e > > Diff: http://git.reviewboard.kde.org/r/106665/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliwkas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
