----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106523/#review19265 -----------------------------------------------------------
See my comments, otherwise this looks fine to me. systemsettings/icons/CategorizedView.cpp <http://git.reviewboard.kde.org/r/106523/#comment15267> I don't know the specifics of the bug which is being worked around, but would it not be more efficient to set the singleStep property once, in the CategorizedView constructor? - Ben Cooksley On Sept. 21, 2012, 11:26 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106523/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2012, 11:26 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Smooth scroll by mousewheel in SystemSettings > > Work around a bug in Qt, where ScrollByPixel does not work, which makes > scrolling in a view with large delegates very jumpy/difficult. > (the same work around is also used in many other places in KDE, older > dolphin, gwenview, knewstuff3..) > > > Diffs > ----- > > systemsettings/icons/CategorizedView.h f2b064f > systemsettings/icons/CategorizedView.cpp 1a2a1d9 > > Diff: http://git.reviewboard.kde.org/r/106523/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
