> On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: > > Patch looks good now, thanks a lot! > > > > Please commit it to KDE/4.9 and master. > > Sebastian Kügler wrote: > Ah, crap. I missed your question about the possible BIC issue. Can > someone answer this question? > > """ > Is it okay to remove a no longer needed overload of a virtual function > from a class in kde-workspace/libs, or is there some BC constraint? > """ > (the patch changes updatePreferredSize() to updateSize()) > > Please hold off pushing the patch for now, we really don't want to ship > any BIC issues into a stable branch. :/ > > Marco Martin wrote: > yes, that patch breaks bc. > however a library in kde-workspace has no promise of bc. > only one thing, shouldn't break released software, so it's fine to commit > to master but not backporting to 4.9 > > Ralf Jung wrote: > Actually, the patch presented here does not break BC. This function I > renamed is part of CalendarPrivate and therefore can not be used from the > outside. > The BC breakage would (possibly) be introduced by removing > Calendar::resizeEvent, which is why I just stubbed it out to call the > superclass function.
As Marco said, please push only to master. :) Thanks... - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/#review19132 ----------------------------------------------------------- On Sept. 18, 2012, 5:40 p.m., Ralf Jung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106441/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2012, 5:40 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Currently, the size of the calendar opened when clicking a clock is sometimes > set incorrectly, see the bug I linked to this review request. This patch > fixes the bug by setting a proper minimal size on the calendar widget and > updating the displayed events after configuration changes. > > > This addresses bug 306762. > http://bugs.kde.org/show_bug.cgi?id=306762 > > > Diffs > ----- > > libs/plasmaclock/calendar.cpp 7ea70c2 > > Diff: http://git.reviewboard.kde.org/r/106441/diff/ > > > Testing > ------- > > I verified that the bug is fixed - everything behaved as expected. > > > Thanks, > > Ralf Jung > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
