----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105277/#review18677 -----------------------------------------------------------
This review has been submitted with commit 90db8129ff19ec7ce9e0ef294ae7e8a8e9398f7c by Viranch Mehta to branch master. - Commit Hook On June 16, 2012, 3:25 p.m., Viranch Mehta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105277/ > ----------------------------------------------------------- > > (Updated June 16, 2012, 3:25 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch implements support for computers with multiple batteries in the > battery monitor applet. > > I'm not sure if I should push it now or after the unfreeze. This review > addresses the bug #301533 > > > This addresses bug 301533. > http://bugs.kde.org/show_bug.cgi?id=301533 > > > Diffs > ----- > > plasma/generic/applets/batterymonitor/contents/code/logic.js PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml > 08a46ec > > Diff: http://git.reviewboard.kde.org/r/105277/diff/ > > > Testing > ------- > > Added dummy battery sources in power management engine and tested with it. > Works fine, as expected with such sources. > > Can someone with multiple batteries please test the patch? since I don't have > a computer with multiple batteries. > > > Thanks, > > Viranch Mehta > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
