On Thursday 06 September 2012, Aaron J. Seigo wrote: > hi.. > > since reviewboard is not accepting my diff to plasma-mobile (either from > the website or via the usual post-review; it seems to think there is no > components/mobilecomponents/fallbackcomponent.cpp file... :/) i'm posting > a patch here that implements some basic caching to avoid hitting disk more > often than necessary. it uses QCache so as to prevent unlimited memory > usage.
definitely +1 for the patch > also, this seems to be the only thing from the plasma-mobile repository > that SLC now uses. since it is so trivial, i'm considering just copying it > into SLC wholesale. the only other thing that uses FallbackComponent is > the ResourceDelegate that is used extensively in plasma-mobile, so the > functionality of FallbackComponent is indeed needed, though i wonder if it > needs to be its own entire componet just to access that one small bit of > code. might be nicer if it were it were just part of ResourceDelegate .. > but that's pure QML so probably not possible. > > anyways ... patch and SLC usage -> thoughts? about the moving, where to put it... i'm not sure. at the beginning it should have been a common component used a lot... then as it appears now its use case is pretty small, used only in exactly 2 places. there is a way it can become a part of ResourceDelegate (and in this case it should be duplicated in the slc delegate as well) resourcedelegate may become a c++ component creating the child delegate directly from c++, so this code can be incorporated. the few lines of qml becomes not-so-few, but it should be possible to retain behavior and api in the conversion Cheers, Marco Martin _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
