> On July 26, 2012, 10:57 a.m., Marco Martin wrote: > > what i can say quickly looking at it is that it looks cleaner and more > > expandible than the old one. > > of course is a bit big, so will indeed need more testing, but most > > important thing for the first merge is that there aren't significant > > regressions compared to what there is already (konq, firefox, opera) > > Marco Gulino wrote: > Hello, any update on this one? Could it be shipped for 4.10? > Thanks
yes, sure :) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105673/#review16476 ----------------------------------------------------------- On July 26, 2012, 10:23 a.m., Marco Gulino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105673/ > ----------------------------------------------------------- > > (Updated July 26, 2012, 10:23 a.m.) > > > Review request for Plasma. > > > Description > ------- > > I've nearly finished my work on the Bookmarks krunner, at least I think it's > ready for a review. > Main focus: add support for chrome (and chromium). > Side effects: refactoring, a few unit tests, and Favicons for firefox (it's > very similar for chrome, they're stored as sqlite blob, so adding favicon for > chrome meant making easy to add them to firefox too). > I also removed some code seeming dead, or duplicated. > > I'm mostly unhappy with the favicon fetch from firefox and chrome: i had to > save them to temp file since it's impossible to load QPixmap in krunner > plugins. > > What's still missing: maybe a little more testing (both unit and manual) and > cleanup. > > branch: plasma/bookmarksrunner-chrome-gulino, path > /plasma/generic/runners/bookmarks > > > Diffs > ----- > > plasma/generic/runners/bookmarks/.gitignore PRE-CREATION > plasma/generic/runners/bookmarks/CMakeLists.txt 39d7834 > plasma/generic/runners/bookmarks/bookmarkmatch.h PRE-CREATION > plasma/generic/runners/bookmarks/bookmarkmatch.cpp PRE-CREATION > plasma/generic/runners/bookmarks/bookmarksrunner.h d7545af > plasma/generic/runners/bookmarks/bookmarksrunner.cpp aa3d45d > plasma/generic/runners/bookmarks/bookmarksrunner_defs.h PRE-CREATION > plasma/generic/runners/bookmarks/browser.h PRE-CREATION > plasma/generic/runners/bookmarks/browserfactory.h PRE-CREATION > plasma/generic/runners/bookmarks/browserfactory.cpp PRE-CREATION > plasma/generic/runners/bookmarks/browsers/chrome.h PRE-CREATION > plasma/generic/runners/bookmarks/browsers/chrome.cpp PRE-CREATION > plasma/generic/runners/bookmarks/browsers/chromefindprofile.h PRE-CREATION > plasma/generic/runners/bookmarks/browsers/chromefindprofile.cpp > PRE-CREATION > plasma/generic/runners/bookmarks/browsers/findprofile.h PRE-CREATION > plasma/generic/runners/bookmarks/browsers/firefox.h PRE-CREATION > plasma/generic/runners/bookmarks/browsers/firefox.cpp PRE-CREATION > plasma/generic/runners/bookmarks/browsers/kdebrowser.h PRE-CREATION > plasma/generic/runners/bookmarks/browsers/kdebrowser.cpp PRE-CREATION > plasma/generic/runners/bookmarks/browsers/opera.h PRE-CREATION > plasma/generic/runners/bookmarks/browsers/opera.cpp PRE-CREATION > plasma/generic/runners/bookmarks/favicon.h PRE-CREATION > plasma/generic/runners/bookmarks/favicon.cpp PRE-CREATION > plasma/generic/runners/bookmarks/faviconfromblob.h PRE-CREATION > plasma/generic/runners/bookmarks/faviconfromblob.cpp PRE-CREATION > plasma/generic/runners/bookmarks/fetchsqlite.h PRE-CREATION > plasma/generic/runners/bookmarks/fetchsqlite.cpp PRE-CREATION > plasma/generic/runners/bookmarks/plasma-runner-bookmarks.desktop b752591 > plasma/generic/runners/bookmarks/tests/CMakeLists.txt PRE-CREATION > > plasma/generic/runners/bookmarks/tests/chrome-config-home/.config/chromium/Local > PRE-CREATION > > plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json > PRE-CREATION > > plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json > PRE-CREATION > plasma/generic/runners/bookmarks/tests/testchromebookmarks.h PRE-CREATION > plasma/generic/runners/bookmarks/tests/testchromebookmarks.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105673/diff/ > > > Testing > ------- > > > Thanks, > > Marco Gulino > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
