----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/#review17790 -----------------------------------------------------------
I do not see a reason why the hidden panel should not be allowed to go above a fullscreen window. True it's not possible for the normal panel case, but hidden panel is kind of special. Apart from that I think you modified the wrong place as it's only about the hint and you bound it with whether compositing is used. - Martin Gräßlin On Aug. 20, 2012, 6:26 p.m., Alexey Shmalko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106110/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2012, 6:26 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Make autohide panel do not intercept events in fullscreen app. > > I changed PanelView::shouldHintHide() to return true if current active > application is in fullscreen mode. So in fullscreen applications panel will > be always hidden. > > > This addresses bugs 297920 and 305497. > http://bugs.kde.org/show_bug.cgi?id=297920 > http://bugs.kde.org/show_bug.cgi?id=305497 > > > Diffs > ----- > > plasma/desktop/shell/panelview.cpp 7713740 > > Diff: http://git.reviewboard.kde.org/r/106110/diff/ > > > Testing > ------- > > > Thanks, > > Alexey Shmalko > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
