> On Aug. 14, 2012, 10:39 a.m., Frank Reininghaus wrote: > > OK, thanks for the explanation! If there is a way to opt-out, this can go > > into master from my point of view. > > > > I've noticed a possible problem though: the CMake message about kactivities > > in your patch says "STRONGLY_RECOMMENDED: Needed for Dolphin and Konqueror > > integration with activities". However, in its current state your patch will > > only integrate Dolphin with activities, not Konqueror. Note that > > DolphinViewContainer is only used by Dolphin, the Konqueror equivalent is > > DolphinPart. Both are wrappers for DolphinView. If you want to integrate > > both with activities, it might therefore be better to move your changes to > > DolphinView.
I intended to make a separate patch for konq - to support all things open by it. Will remove it from the message until i do patch it . - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105973/#review17365 ----------------------------------------------------------- On Aug. 11, 2012, 10:27 a.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105973/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2012, 10:27 a.m.) > > > Review request for Dolphin, KDE Base Apps, Plasma, and Frank Reininghaus. > > > Description > ------- > > Dolphin reports open locations to the activity manager (KAMD). > > Reasoning behind the feature: > - KAMD ranks the locations based on the time the user has spent in them > - Share-Like-Connect applet can know what is open in dolphin > > This is an compile-time-optional feature - turned on if there is > libkactivities installed. > > The find_package(KActivities) is located in the root CMakeLists.txt because > this feature should also be implemented for Konqueror. > > > Diffs > ----- > > dolphin/src/dolphinviewcontainer.cpp 31c82d6 > dolphin/src/dolphinviewcontainer.h fd52806 > CMakeLists.txt fab73c1 > config-apps.h.cmake 43764ef > dolphin/src/CMakeLists.txt 5c1a6da > > Diff: http://git.reviewboard.kde.org/r/105973/diff/ > > > Testing > ------- > > With SDI windows, with tabs. > > > Screenshots > ----------- > > S-L-C showing dolphin folder > http://git.reviewboard.kde.org/r/105973/s/672/ > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
