----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/#review17372 -----------------------------------------------------------
Ship it! plasma/desktop/containments/desktop/desktop.cpp <http://git.reviewboard.kde.org/r/105989/#comment13583> QString::trim().isEmpty() maybe? That could be collated with one of the previous checks even, making it more readable and more robust I think as well. Once changed, this patch can go in. Minor nitpick, otherwise ready to go. - Sebastian Kügler On Aug. 14, 2012, 11:06 a.m., Jekyll Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105989/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 11:06 a.m.) > > > Review request for Plasma. > > > Description > ------- > > This bug report is quite similar to bug 285350, so the proposed patch is > similar and simple . > > > This addresses bug 304805. > http://bugs.kde.org/show_bug.cgi?id=304805 > > > Diffs > ----- > > plasma/desktop/containments/desktop/desktop.cpp e5e02c0 > > Diff: http://git.reviewboard.kde.org/r/105989/diff/ > > > Testing > ------- > > > Thanks, > > Jekyll Wu > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
