----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105858/#review17103 -----------------------------------------------------------
Ship it! Oups, good catch! - Aurélien Gâteau On Aug. 4, 2012, 8:33 p.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105858/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2012, 8:33 p.m.) > > > Review request for Plasma and Aurélien Gâteau. > > > Description > ------- > > In checking the above bug, I found that the calculation of the timeout of a > notification has a nice idea implemented, but it does not > work due to a bug. > The code should create longer timeouts for longer texts, but have at least 5 > seconds. > Due to using 2000 + qMin(timeout, 3000), the result will be maximum 5 > seconds. This patch changes this to qMax so that > we really get longer timeouts than 5 seconds. > > > This addresses bug 178411. > http://bugs.kde.org/show_bug.cgi?id=178411 > > > Diffs > ----- > > plasma/generic/dataengines/notifications/notificationsengine.cpp caaca27 > > Diff: http://git.reviewboard.kde.org/r/105858/diff/ > > > Testing > ------- > > notify-send with very long text and debugging output of timeout > > > Thanks, > > Martin Koller > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
