> On July 26, 2012, 10:23 a.m., Marco Martin wrote: > > it should depend from the border size as well. > > right now it would break panels less that 40 px tall. > > Reza Shah wrote: > My patch only for placement at desktop. > Does it also affect the placement at panel?
yeah, in this case the patch is fine - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105577/#review16470 ----------------------------------------------------------- On July 15, 2012, 12:19 p.m., Reza Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105577/ > ----------------------------------------------------------- > > (Updated July 15, 2012, 12:19 p.m.) > > > Review request for Plasma and Davide Bettio. > > > Description > ------- > > bug reference: https://bugs.kde.org/show_bug.cgi?id=301674 > using previous minimum size the applet drawn incorrectly. > this patch slightly increased the minimum size of binary clock applet when > placed in desktop. > > > This addresses bug 301674. > http://bugs.kde.org/show_bug.cgi?id=301674 > > > Diffs > ----- > > applets/binary-clock/binaryclock.cpp 6e706de > > Diff: http://git.reviewboard.kde.org/r/105577/diff/ > > > Testing > ------- > > master > > > Screenshots > ----------- > > before - after > http://git.reviewboard.kde.org/r/105577/s/637/ > > > Thanks, > > Reza Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel