> On July 14, 2012, 8:38 p.m., Greg T wrote: > > Why didn't you replace the commas in the localized keyword entrys?
Because those localized entries are supposed to be updated by scripty(in other words, the translation teams). IIRC, If I modify those localized entries manually, scripty will simply remove them later. - Jekyll ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105555/#review15859 ----------------------------------------------------------- On July 13, 2012, 2:49 p.m., Jekyll Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105555/ > ----------------------------------------------------------- > > (Updated July 13, 2012, 2:49 p.m.) > > > Review request for Plasma. > > > Description > ------- > > It is similar to review 105553. > > According to the FDO specification[1][2], the type of "Keywords" is > "localestring(s)", where multiple values are separated by a semicolon. > > The affected two .desktop files use comma instead of semicolon to separate > multiple values. That seems to be the expected behavior for "X-KDE-Keywords", > but not for "Keywords". > > The patch simply uses semicolon and adds the trailing semicolon. > > > [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html > [2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html > > > Diffs > ----- > > applets/microblog/plasma-applet-microblog.desktop b8d3864 > > Diff: http://git.reviewboard.kde.org/r/105555/diff/ > > > Testing > ------- > > > Thanks, > > Jekyll Wu > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
