----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105447/#review15421 -----------------------------------------------------------
Ship it! yes, i think right now is the least painful way to have it right. the code is ok. what we have to remember is for plasma2 we may want to not have to do that again, so api in libplasma may heve to be retought. but +1 for doing this way for now - Marco Martin On July 5, 2012, 9:05 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105447/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 9:05 a.m.) > > > Review request for Plasma, KDE Usability and Marco Martin. > > > Description > ------- > > When the widget explorer is oriented vertically, applet tooltips shows on top > of other applets instead of showing on the right or on the left. This patch > fixes it in a not-too intrusive way (original patch affected kdelibs and > kde-runtime as well). If possible I would like this patch to be applied to > the KDE/4.9 branch as well. > > > Diffs > ----- > > libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml > cc84e6c > libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h 31308d2 > libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 9b19f88 > > Diff: http://git.reviewboard.kde.org/r/105447/diff/ > > > Testing > ------- > > Tested with panels on all edges. > > > Screenshots > ----------- > > before-after > http://git.reviewboard.kde.org/r/105447/s/616/ > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
