----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104764/#review14893 -----------------------------------------------------------
This review has been submitted with commit 88627b1f9eaa778b80aaf6cd6bd5f4026b5fade0 by Gregor Tätzner to branch master. - Commit Hook On April 27, 2012, 6:14 p.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104764/ > ----------------------------------------------------------- > > (Updated April 27, 2012, 6:14 p.m.) > > > Review request for Plasma. > > > Description > ------- > > isDesktopFile() of KDesktopFile only looks at the file extension. This is not > sufficient in a lot of cases, i.e. if you create a 'Link to Location' with > dolphin it creates a desktop file without the .desktop extension. > isDesktopFile check of KFileItem seems to working better and doesn't just > look at the file suffix. > > > This addresses bug 266870. > http://bugs.kde.org/show_bug.cgi?id=266870 > > > Diffs > ----- > > plasma/generic/applets/icon/icon.cpp 4bdbae4 > > Diff: http://git.reviewboard.kde.org/r/104764/diff/ > > > Testing > ------- > > bug fixed > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
