----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105269/ -----------------------------------------------------------
(Updated June 16, 2012, 12:03 p.m.) Review request for Plasma. Changes ------- The svg has elements for the vertical sliders, so this patch uses them where appropriate. Also the shadow component on the handle is now rotated back. This is still moreless a workaround, but I think it's good enough for now. Description ------- The vertical sliders are rotated horizontal sliders including all the light effects, which looks bad as it appears like there are two different light sources. This patch rotates back the slider handle, so all the handles have consistent shadowing. The grooves should also have consistent shadow, but that may come in later patch (also it's way less visible). See screenshots. Diffs (updated) ----- plasma/declarativeimports/plasmacomponents/qml/Slider.qml 5867164 Diff: http://git.reviewboard.kde.org/r/105269/diff/ Testing ------- Tested on widget gallery. Screenshots ----------- Before http://git.reviewboard.kde.org/r/105269/s/603/ After http://git.reviewboard.kde.org/r/105269/s/604/ Thanks, Martin Klapetek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
