----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review14677 -----------------------------------------------------------
applets/showdashboard/showdashboard.cpp <http://git.reviewboard.kde.org/r/105234/#comment11590> If you do this, can you still put this in a panel? I think it will stop resizing when the panel gets smaller than 50 in height. Which is worse. I would wrap in if (formFactor == Plasma::Planar) { setMinimumSize(...) } Also Battery applet is (now) set to a minimum size of 32x32 on the desktop. Would be good to have some consistency. applets/systemloadviewer/systemloadviewer.cpp <http://git.reviewboard.kde.org/r/105234/#comment11589> This isn't right. Look down a few lines. It gets set again. - David Edmundson On June 12, 2012, 8:43 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105234/ > ----------------------------------------------------------- > > (Updated June 12, 2012, 8:43 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This fixes the minimum size of the following applets: showdashboard, > systemloadviewer, pastebin, weatherstation and timer. > Some sizes were to small, so there were visual glitches and some applets had > no minimum value set. > > I have no commit rights. > > > Diffs > ----- > > applets/pastebin/pastebin.cpp 208e6a3 > applets/showdashboard/showdashboard.cpp 1c2f623 > applets/systemloadviewer/systemloadviewer.cpp b852256 > applets/timer/timer.cpp ba5ee66 > applets/weatherstation/weatherstation.cpp 8ada9c2 > > Diff: http://git.reviewboard.kde.org/r/105234/diff/ > > > Testing > ------- > > Run the applets with their new minimum size, and minimized. > > > Thanks, > > Maarten De Meyer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
