----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105190/#review14549 -----------------------------------------------------------
Ship it! great catches.. thanks! :) - Aaron J. Seigo On June 9, 2012, 11:38 a.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105190/ > ----------------------------------------------------------- > > (Updated June 9, 2012, 11:38 a.m.) > > > Review request for Plasma. > > > Description > ------- > > 1. avoid a memory leak > 2. faster check for emptiness > 3. arg(x,y) != arg(x).arg(y).... also, y can be 1.0 to be equal to the > internal version somewhere bellow in the code. > 4. check for data emptiness before it is used > > > Diffs > ----- > > applets/kdeobservatory/src/commithistoryview.cpp 6152ed3 > applets/kimpanel/backend/scim/main.cpp 2f2bacc > applets/mediaplayer/dbus/rootdbushandler.cpp 2dd2874 > containments/groupingdesktop/lib/groupexplorer/groupicon.cpp 120ead3 > > Diff: http://git.reviewboard.kde.org/r/105190/diff/ > > > Testing > ------- > > I've using this patch too much time (too busy). > > > Thanks, > > Jaime Torres Amate > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
