----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105159/ -----------------------------------------------------------
(Updated June 6, 2012, 2:23 p.m.) Review request for Plasma and Sebastian Kügler. Changes ------- Apply the same fix to touch components. I don't know how to test them though, so feedback is welcome. Description ------- Plasma::LineEdit uses the button text color for its text. Do the same in PlasmaComponents.TextField to avoid white text on white background with Oxygen theme. Also use button text color for PC.TextArea because it uses the same background frame as PC.TextField (P.TextEdit, its C++ equivalent, does not have any background frame) Diffs (updated) ----- plasma/declarativeimports/plasmacomponents/platformcomponents/touch/TextArea.qml 244e8c3 plasma/declarativeimports/plasmacomponents/platformcomponents/touch/TextField.qml 76aff68 plasma/declarativeimports/plasmacomponents/qml/TextArea.qml f82842e plasma/declarativeimports/plasmacomponents/qml/TextField.qml 1230d33 Diff: http://git.reviewboard.kde.org/r/105159/diff/ Testing ------- Run Plasma widget gallery from kdeexamples before and after the patch, see attached screenshots. Note: the "before" screenshot corresponds to the state of the classes after I reverted the changes which hardcoded their text colors to black. Screenshots ----------- before http://git.reviewboard.kde.org/r/105159/s/596/ after http://git.reviewboard.kde.org/r/105159/s/597/ Thanks, Aurélien Gâteau
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
