> On June 1, 2012, 6:40 p.m., Aaron J. Seigo wrote:
> > publisher/remoteinstaller/remoteinstaller.cpp, line 88
> > <http://git.reviewboard.kde.org/r/105032/diff/3/?file=66054#file66054line88>
> >
> >     this is the command that fails when there is no display env var set?
> >     
> >     if so .. just don't do it :) plasmapkg does this for us if it is 
> > possible, anyways. this would also remove the need to set the display 
> > variable.
> >     
> >     (btw, if the plasmapkg command is run and a kdeinit backed session is 
> > running on the device, kbuildsycoca will run automatically after a few 
> > seconds anyways. so worst case scenario is that it takes a moment to run)

we don't need the DISPLAY stuff. So I remove the relative code.


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105032/#review14344
-----------------------------------------------------------


On June 1, 2012, 6:11 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105032/
> -----------------------------------------------------------
> 
> (Updated June 1, 2012, 6:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> in terietor/remoteinstaller I have create a remote installer.
> The goal is to install the projects remotely to another computer.
> 
> You access the remote install either inside plasmate or using the 
> plasmaremoteinstaller binary.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 12f8a3a 
>   publisher/publisher.h 5f40ae0 
>   publisher/publisher.cpp fd87364 
>   publisher/remoteinstaller/advancedmodewidget.ui PRE-CREATION 
>   publisher/remoteinstaller/remoteinstaller.h PRE-CREATION 
>   publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION 
>   publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION 
>   publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION 
>   publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION 
>   publisher/remoteinstaller/standalone/main.cpp PRE-CREATION 
>   publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATION 
>   publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105032/diff/
> 
> 
> Testing
> -------
> 
> I couldn't find any bugs in the remote installer, but the proccess fails 
> during KIO::copy.
> Apparently I am not writing correct something in the fish protocol.
> Right now the remote installer tries to do the above
> 
> KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, 
> "fish://user@ip/home/user")
> 
> but it fails
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to