----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104917/#review13725 -----------------------------------------------------------
Ship it! was just that sroting with a proxy tends to cause the same flickering problems, but yeah, for now go for it, we can always optimize after ;) - Marco Martin On May 11, 2012, 2:13 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104917/ > ----------------------------------------------------------- > > (Updated May 11, 2012, 2:13 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Description > ------- > > When RunnerModel receives the matchesChanged() from RunnerManager, it resets > itself and replace its copy of matches with the new one. This cause some > flicker when the model is used with a QML ListView because the view clears > itself each time the model is reset. > > Ideally, RunnerManager should provide more fine-grained updates to > RunnerModel, but for now I found the below patch to give good results. It > basically checks if the new match list is equal to the old one plus some new > items. If this is the case, it uses beginInsertRows() and endInsertRows() > instead of resetting the model. > > Note: the code needs a recent version of kdelibs KDE/4.8 branch because it > requires the != operator for Plasma::QueryMatch, which I added earlier today. > > > Diffs > ----- > > plasma/declarativeimports/krunnermodel/runnermodel.cpp 7c5485b > > Diff: http://git.reviewboard.kde.org/r/104917/diff/ > > > Testing > ------- > > Tested with SAL-QML (currently in kde-workspace, in plasma/sreich/sal-qml). > Gets lots of flickering because items created by the SAL-QML view fades in > when added. Flickering goes away after the patch. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
