----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104760/#review13710 -----------------------------------------------------------
Ship it! this is fine for libplasma1; but really we'll need something for QML2's scene graph later in libplasma2. plasma/service.h <http://git.reviewboard.kde.org/r/104760/#comment10887> to me, however, this looks like an odd step towards supporting QML at a time when QML is moving away from QGraphicsView. it would be nicer to simply allow associating with a QML Item. in any case, we can do that in libplasma2... - Aaron J. Seigo On April 27, 2012, 8:47 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104760/ > ----------------------------------------------------------- > > (Updated April 27, 2012, 8:47 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Allow QML items to be associated with operations in Plasma::Service > > QML items derive from QGraphicsObject, but not QGraphicsWidget. We > actually only need QGraphicsObject (for the enabled property). > > This allows QML items to be associated with operations (eg: in declarative > applets). > > The new methods are called (dis)associateItem to prevent disambiguation > issues. > > > Diffs > ----- > > plasma/private/service_p.h 8afef0b6f1ca8bfa11b271fd3b29bc033a94c9a5 > plasma/service.h 314909ba84702beb16a36208d1a3c058b1a20f77 > plasma/service.cpp 3846e817d013cf26e2dcf57c5fd86783f061bb13 > > Diff: http://git.reviewboard.kde.org/r/104760/diff/ > > > Testing > ------- > > Tested with a QML plasmoid in plasmoidviewer. > > > Thanks, > > Alex Merry > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
