----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104735/ -----------------------------------------------------------
Review request for Plasma and David Edmundson. Description ------- This patch fixes two issues in ToolButton layout: 1. Make sure there is some space between the button icon and its text 2. Do not enforce a minimum width The reason for #2 is that having a minimum width does not make much sense for a ToolButton: - It should aim at using the minimum amount of horizontal space when used in a ToolBar. - It looks unbalanced when used with an icon because the content is flushed to the left, leaving a large amount of white-space on the right. (See attached screenshots) Diffs ----- plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 0447a69 Diff: http://git.reviewboard.kde.org/r/104735/diff/ Testing ------- Run attached test script, you should notice the differences in spacing between button icon and text, as well as in the white-space on the right of the button. Screenshots ----------- Before http://git.reviewboard.kde.org/r/104735/s/545/ After http://git.reviewboard.kde.org/r/104735/s/546/ Thanks, Aurélien Gâteau
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
