----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104603/ -----------------------------------------------------------
(Updated April 15, 2012, 8:10 a.m.) Review request for Plasma. Changes ------- Set correct bugs' ids. Description (updated) ------- Closes: http://bugs.kde.org/show_bug.cgi?id=265456 Partialy closes: https://bugs.kde.org/show_bug.cgi?id=295410 "On screen display" notification when changing activities. Displays the user icon and the name. It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand. This could be as well implemented on KWin, but i did as a kamd plugin for fun :P. For the time being i think it is not correct to force such plugin (it would be cool is kamd's plugins were managed via systemsettings) without an option to enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed. This addresses bugs 265456 and 295410. http://bugs.kde.org/show_bug.cgi?id=265456 http://bugs.kde.org/show_bug.cgi?id=295410 Diffs ----- service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CREATION service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104603/diff/ Testing ------- Changed activities and it works. Screenshots ----------- without kwin effects http://git.reviewboard.kde.org/r/104603/s/531/ with kwin effects http://git.reviewboard.kde.org/r/104603/s/532/ after kwin effects disabledd (possible bug) http://git.reviewboard.kde.org/r/104603/s/533/ Thanks, makis marimpis
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
