-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/
-----------------------------------------------------------
Review request for Plasma and Marco Martin.
Description
-------
This patch essentially contains the new QML lock logout applet, along with
required changes to powermanagement engine.
The patch contains *some* irrelevant code too (in powermanagement data engine)
since the same branch has QML battery applet. So it'd be best to checkout
plasma/viranch/powermanagementservices branch and compile
plasma/generic/{applets/lockout,dataengines/powermanagement} instead of using
the attached patch.
Two pending issues with the applet:
- There is no shine on the icons on hover.
- Sleep/Hibernate actions do not ask for confirmation, as does the current C++
version
Comments welcome on this thread :)
Diffs
-----
plasma/generic/applets/lock_logout/CMakeLists.txt a19615b
plasma/generic/applets/lock_logout/contents/config/main.xml PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/config.ui PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/data.js PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/lockout.qml PRE-CREATION
plasma/generic/applets/lock_logout/lockout.h 94f33cf
plasma/generic/applets/lock_logout/lockout.cpp 830e64b
plasma/generic/applets/lock_logout/lockoutConfig.ui d9285c2
plasma/generic/applets/lock_logout/metadata.desktop PRE-CREATION
plasma/generic/applets/lock_logout/plasma-applet-lockout.desktop d8a4337
plasma/generic/dataengines/powermanagement/CMakeLists.txt 9f2a528
plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb
plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
plasma/generic/dataengines/powermanagement/powermanagementservice.operations
ad1301f
Diff: http://git.reviewboard.kde.org/r/104592/diff/
Testing
-------
- Tested inside horizontal/vertical panels and floating on desktop, sizing
works as expected.
- There may be some unexpected behavior if the panel containing the applet is
changed from being horizontal to vertical or vice-versa.
Screenshots
-----------
Screenshot of the applet on desktop
http://git.reviewboard.kde.org/r/104592/s/526/
Thanks,
Viranch Mehta
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
