----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104497/#review12196 -----------------------------------------------------------
I doubt that Esc is the only key that shows this issue. For example, just pressing Return on empty desktop also leads to a space in KRunner line. Instead of a black list, I propose a sanity check, e.g. if the key pressed actually is a printable character. - Christoph Feck On April 6, 2012, 11:06 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104497/ > ----------------------------------------------------------- > > (Updated April 6, 2012, 11:06 a.m.) > > > Review request for Plasma and Vitor Boschi da Silva. > > > Description > ------- > > When pressing Escape on an empty workspace, KRunner pops up and is introduced > a white-space character, preventing the input from being recognized. > This patch makes KRunner not pop up when pressing the Escape key. > > > This addresses bug 285350. > http://bugs.kde.org/show_bug.cgi?id=285350 > > > Diffs > ----- > > plasma/desktop/containments/desktop/desktop.cpp 8bcb877 > > Diff: http://git.reviewboard.kde.org/r/104497/diff/ > > > Testing > ------- > > KRunner does not pop up when pressing Escape key, works fine in other ways. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
