----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12067 -----------------------------------------------------------
service/plugins/globalshortcuts/globalshortcuts.h <http://git.reviewboard.kde.org/r/104428/#comment9501> Use "fetchAllActivities(const QDBusMessage & message)" here if possible. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9502> remove extra line break. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9503> please stick to the code style, use "QString & activity" here. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9504> Please avoid using QDBusReply or waitForFinished. Since kactivitymanager is a key part of Plasma Desktop any delay here can cause the whole desktop to freeze for some seconds. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9506> Code style, please use "KAction * action" service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9505> You can replace this and the next two lines with: action->setText(i18nc("@action", "Switch to activity \"%1\"", reply.value())); service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9507> Normalize this connect statement (just remove "const" word, "&" char and any space inside the parentesis in SIGNAL() and SLOT(). They are not needed and cause QObject::connect to be a bit slower. - Lamarque Vieira Souza On March 31, 2012, 4:19 p.m., makis marimpis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104428/ > ----------------------------------------------------------- > > (Updated March 31, 2012, 4:19 p.m.) > > > Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić. > > > Description > ------- > > (follows discarded review: 104391) > > The plugin adds global keyboard shortcuts for changing the activity. > Defaults start from Qt::MetaModifier + Qt::Key_F1. > > Initially, this functionality was implemented (without correct results) using > KActitivities::Controller. > Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds > delay - so it really needs modification/and i would like more guidance > related to dbus :D. > Other than that, feedback is needed. > > > This addresses bugs 265069 and 273467. > http://bugs.kde.org/show_bug.cgi?id=265069 > http://bugs.kde.org/show_bug.cgi?id=273467 > > > Diffs > ----- > > service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 > service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION > > service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop > PRE-CREATION > service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION > service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION > service/plugins/globalshortcuts/keyboardbindings.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104428/diff/ > > > Testing > ------- > > Logged in. > Used the default shortcuts to switch activities. > It works! > > > Thanks, > > makis marimpis > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
