-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103915/#review10493
-----------------------------------------------------------

Ship it!


- Marco Martin


On Feb. 10, 2012, 7:16 p.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103915/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2012, 7:16 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Fix folderview behavior in panels with regard to the collapsed mode.
> 
> 1)Keep it small like Trash or Show desktop / Dashboard (ConstrainedSquare, 
> minimumSize & sizeHint - code taken from Trash, which behaves properly when 
> in a panel with regard to scaling).
> 2)Update icon size on panel icon size change.
> 3)No duplicates - if (m_iconWidget) check - the absence of such a  check 
> resulted in Really Weird(TM) things going on, like duplicates or ghost 
> folderviews.
> 
> 
> This addresses bug 244557.
>     http://bugs.kde.org/show_bug.cgi?id=244557
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/folderview.cpp c3b6e2a 
> 
> Diff: http://git.reviewboard.kde.org/r/103915/diff/diff
> 
> 
> Testing
> -------
> 
> Tested the hell out of it:dragged the panel around the screen on all the 4 
> screen edges - no problems noticed. Changed Panel icon size in the Icons KCM, 
> updates on the fly.
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to